new copy button

[adamalston]

Fixes #12

Overview

• Make copy button show up if there is text in the revised TextArea
• Implement functionality to copy text from the TextArea

Any feedback and/or edits are appreciated

[filipecorrea]

Hi @adamalston. Thanks for your contribution. It's not clear to me why you did not follow the layout and added a new button on this screen. Do you think there is a problem with the proposed layout?

[adamalston]

The issue said:

Add a ghost button in the Review box so that the user can copy what has been translated to the clipboard.

I followed this and put the button in the review box. Also, the issue didn't specify whether the old button should be removed. Any feedback or edits were expected since the instructions were a little unclear.

[filipecorrea]

You're right, the issue wasn't clear enough. Sorry about that.

I just updated the issue description to the appropriate behavior that's being expected. I hope you don't mind updating your code to reflect that.

[camilasb]

Can I see how it's like somehow to check out the design?

[filipecorrea]

It's working as expected, but I'm missing unit tests. I think it would be good to check if (and when) the button is rendered and validate what's happening when it's clicked.

[filipecorrea]

@camilasb Adam updated the screenshot in the pull request description, but I'm sending another one anyway:

While testing this one, I found two SCSS problems unrelated to this issue: #25 and #26.

[adamalston]

I do not have much experience testing buttons and onClick events so any assistance there would be appreciated. Further, if someone wants to contribute the tests themselves, I would fine with that.

I can confirm #25 on my end as well (macOS, Firefox 80.0.1). My screenshot appears different because I am using a dark mode extension which automatically makes the page darker and increases contrast between text and background.

[filipecorrea]

@adamalston React Test Utilities is a good place to start and this example has all that you need to create a src/content/UserPage/UserPage.test.js.

Please give a try and I can continue helping you using code reviews.

[camilasb]

@filipecorrea if there's an env for testing, let me know :D i can take a look at that as well

[filipecorrea]

@camilasb We don't have this code deployed yet. You'll need to run it locally at this moment.

[camilasb]

@camilasb We don't have this code deployed yet. You'll need to run it locally at this moment.

i see! tks :D