Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem initializer #101

Merged
merged 11 commits into from
Nov 28, 2018
Merged

Problem initializer #101

merged 11 commits into from
Nov 28, 2018

Conversation

sesevgen
Copy link
Collaborator

  1. Several improvements to COG
  2. Dataset generation pipeline added to COG
  3. problem_initializer helper added.
  4. Refactored recurrent yaml reading into a Worker method.
  5. Added a CheckAndDownload method to Problem.

@tkornuta-ibm
Copy link
Contributor

This pull request introduces 22 alerts and fixes 1 when merging 05f6dd9 into 68ad04d - view on LGTM.com

new alerts:

  • 8 for Comparison using is when operands support __eq__
  • 8 for Unused import
  • 3 for Signature mismatch in overriding method
  • 1 for Unused local variable
  • 1 for Unreachable code
  • 1 for Unnecessary delete statement in function

fixed alerts:

  • 1 for 'import *' may pollute namespace

Comment posted by LGTM.com

@tkornuta-ibm
Copy link
Contributor

This pull request introduces 5 alerts and fixes 3 when merging 7648ac1 into 68ad04d - view on LGTM.com

new alerts:

  • 3 for Signature mismatch in overriding method
  • 1 for Unused local variable
  • 1 for Unnecessary delete statement in function

fixed alerts:

  • 2 for Comparison using is when operands support __eq__
  • 1 for 'import *' may pollute namespace

Comment posted by LGTM.com

@tkornuta-ibm
Copy link
Contributor

This pull request introduces 5 alerts and fixes 3 when merging 7a0e01b into 68ad04d - view on LGTM.com

new alerts:

  • 3 for Signature mismatch in overriding method
  • 1 for Unused local variable
  • 1 for Unnecessary delete statement in function

fixed alerts:

  • 2 for Comparison using is when operands support __eq__
  • 1 for 'import *' may pollute namespace

Comment posted by LGTM.com

@tkornuta-ibm tkornuta-ibm merged commit 919a6f0 into IBM:develop Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants