Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating .secrets.baseline to suppress false positives #115

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jkalandaibm
Copy link
Collaborator

@jkalandaibm jkalandaibm commented Sep 8, 2023

dependency: none

PR summary

The PR's objective is to surppress the newly detected false positive secrets.

Fixes:
List of false positives:

FOUND SECRETS:
File: cis/authenticated-origin-pull-apiv1/v1.ts Line: 718 Type: Secret Keyword
File: directlink.env.properties Line: 2 Type: Secret Keyword
File: test/integration/cis/authenticated-origin-pull-api.v1.test.js Line: 313 Type: Private Key
File: test/unit/cis/authenticated-origin-pull-api.v1.test.js Line: 1011 Type: Private Key

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

dependency: none
Signed-off-by: jkalandaibm <jkalanda@us.ibm.com>
@kennburger kennburger merged commit d89fa45 into master Sep 12, 2023
4 checks passed
@kennburger kennburger deleted the updating-secrets-baseline branch September 12, 2023 17:27
MalarvizhiK pushed a commit that referenced this pull request Sep 12, 2023
# [0.31.0](v0.30.0...v0.31.0) (2023-09-12)

### Features

* updating .secrets.baseline to suppress [secure] positives ([#115](#115)) ([d89fa45](d89fa45))
@MalarvizhiK
Copy link
Member

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants