Skip to content

Commit

Permalink
fix: remove 'module' entry from package.json (#187)
Browse files Browse the repository at this point in the history
A recent change to the library introduced
a separate es6 module for the library to support
tree shaking.  Unfortunately, if an SDK project
doesn't (at a minimum) define the 'main' entry point
in its package.json file, then a problem can occur
due to an es5 vs es6 incompatibility.
This commit provides a tactical fix for this issue
by removing the 'module' entry point from the library's
package.json.  This will prevent webpack from being
able to minimize the resulting application code, but
it will avoid the problem.

Once we have a strategy for rolling out "tree
shakability" in various SDK projects, we can
re-introduce the 'module' entry point.
  • Loading branch information
padamstx authored Jan 14, 2022
1 parent e306094 commit 3a0aea5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "2.17.6",
"description": "Core functionality to support SDKs generated with IBM's OpenAPI SDK Generator.",
"main": "./index.js",
"module": "./es/index.js",
"typings": "./es/index.d.ts",
"sideEffects": false,
"repository": {
Expand Down Expand Up @@ -133,4 +132,4 @@
"coverageDirectory": "./coverage/",
"testEnvironment": "node"
}
}
}

0 comments on commit 3a0aea5

Please sign in to comment.