fix: add new validateParams function #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
force-pushed
the
valdate-params
branch
from
651b25a to
a7ed93d
Compare
This commit adds the "validateParams" function to the node core. This function will be used by the operation code generated by the Node SDK generator to validate the parameters found within a "params" object. It will check for required parameters that are not present, and also check to make sure that all parameters that ARE present are valid (i.e. the param name is among the expected valid parameter names for the operation).
padamstx
force-pushed
the
valdate-params
branch
from
a7ed93d to
4210863
Compare
dpopp07
approved these changes
Dec 6, 2021
|
|
||
| it('should return null if params is an empty object and requiredParams and allParams are null', () => { | ||
| expect(validateParams({}, null, null)).toBeNull(); | ||
| }); |
There was a problem hiding this comment.
So thorough with the null/undefined/empty checks! 😄
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Dec 6, 2021
## [2.17.1](v2.17.0...v2.17.1) (2021-12-06) ### Bug Fixes * add new validateParams function ([#180](#180)) ([514d187](514d187))
|
🎉 This PR is included in version 2.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JurajNyiri
pushed a commit
to JurajNyiri/node-sdk-core
that referenced
this pull request
Aug 22, 2024
Generated SDK source code using: - Generator version 3.26.0 - Specification version 1.0.0-dev0.0.31 - Automation (cloudant-sdks) version 30a5893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the "validateParams" function
to the node core. This function will be used
by the operation code generated by the Node
SDK generator to validate the parameters found
within a "params" object. It will check for
required parameters that are not present, and also
check to make sure that all parameters that ARE present
are valid (i.e. the param name is among the expected
valid parameter names for the operation).
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)