Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harden checks for cookies in error responses #252

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Sep 27, 2023

This commit adds a couple of checks to avoid
problems while handling cookies found in error responses.

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

This commit adds a couple of checks to avoid
problems while handling cookies found in error responses.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx self-assigned this Sep 27, 2023
@padamstx padamstx requested a review from dpopp07 September 27, 2023 17:36
@padamstx
Copy link
Member Author

cc: @emlaver @ricellis

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@padamstx padamstx merged commit 36f7bfe into main Sep 27, 2023
3 checks passed
@padamstx padamstx deleted the issue-3747 branch September 27, 2023 19:56
ibm-devx-sdk pushed a commit that referenced this pull request Sep 27, 2023
## [4.1.2](v4.1.1...v4.1.2) (2023-09-27)

### Bug Fixes

* harden checks for cookies in error responses ([#252](#252)) ([36f7bfe](36f7bfe))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants