fix: Binding parameters issues #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmusse
changed the title
Resolves IBM#147 (comment) IBM#147 (comment) We now set `SQL_NTS` as the indicator instead of the string length. This helps in edge cases like empty string where indicator is set to 0. Also we now ensure the buffer size is at least the size of parameter or the size of the string.
kadler
reviewed
Oct 7, 2022
src/db2ia/dbstmt.cc
Outdated
| param[i].ind = param[i].paramSize; | ||
| // CLI does not honor the buffer size parameter or the output size in the indicator | ||
| // Make the buffer size is at least the size of parameter or the size of the string | ||
| param[i].buf = (char *)calloc(std::max(static_cast<size_t>(param[i].paramSize) + 1, str_length), sizeof(char)); |
There was a problem hiding this comment.
str_length will be without the null terminator too
Suggested change
| param[i].buf = (char *)calloc(std::max(static_cast<size_t>(param[i].paramSize) + 1, str_length), sizeof(char)); | |
| param[i].buf = (char *)calloc(std::max(static_cast<size_t>(param[i].paramSize), str_length) + 1, sizeof(char)); | |
src/db2ia/dbstmt.cc
Outdated
| // Make the buffer size is at least the size of parameter or the size of the string | ||
| param[i].buf = (char *)calloc(std::max(static_cast<size_t>(param[i].paramSize) + 1, str_length), sizeof(char)); | ||
| // Set the indicator to be SQL_NTS | ||
| // this helps in edge cases like empty string where indicator is set 0 |
There was a problem hiding this comment.
Suggested change
| // this helps in edge cases like empty string where indicator is set 0 | |
| // this helps in edge cases like empty string where indicator is set 0 (which CLI doesn't like for some reason) |
src/db2ia/dbstmt.cc
Outdated
Comment on lines
2781
to
2787
| param[i].buf = (char *)calloc(std::max(static_cast<size_t>(param[i].paramSize) + 1, str_length), sizeof(char)); | ||
| // set the indicator to be SQL_NTS | ||
| // this helps in edge cases like empty string where indicator is set 0 | ||
| param[i].ind = SQL_NTS; | ||
| // SQL_PARAM_INPUT_OUTPUT is always set so | ||
| // copy the string to the buffer | ||
| strcpy((char*)param[i].buf, cString); |
There was a problem hiding this comment.
Same changes as above need to be done here too
markdirish
approved these changes
Oct 27, 2022
kadler
approved these changes
Oct 27, 2022
Co-authored-by: Kevin Adler <kadler@us.ibm.com>
Co-authored-by: Kevin Adler <kadler@us.ibm.com>
|
Thanks for fixing this bug @abmusse |
|
Furthermore, I'd need to know when idb-pconnector will be upgraded to use the new version of idb-connector. That's the package we're actually using. |
|
I'm working on getting both packages released today. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147 (comment)
#147 (comment)
We now set
SQL_NTSas the indicator instead of the string length.This helps in edge cases like empty string where indicator is set to 0. Also we now ensure the buffer size is at least the size of parameter or the size of the string.