Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release process #177

Merged
merged 1 commit into from
Feb 2, 2024
Merged

ci: update release process #177

merged 1 commit into from
Feb 2, 2024

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 27, 2023

For more details on the release process, please read docs/RELEASE.md

In previous releases, we packaged the db2ia.node
and other extra files

Now we restrict the files packaged using the files section
of the package.json

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#files

@abmusse abmusse mentioned this pull request Jul 27, 2023
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thought I think some of this stuff could be moved outside of the root. Both the release.sh and README section are really only relevant to us. Perhaps moving the docs to docs/RELEASE.md and putting release.sh under .github?

@abmusse
Copy link
Member Author

abmusse commented Jul 27, 2023

That sounds good to me as well!

@abmusse abmusse requested a review from kadler July 27, 2023 21:00
@abmusse abmusse force-pushed the build-add-release-it branch from d9570a5 to 44065d3 Compare August 2, 2023 23:14
@abmusse abmusse changed the title ci: add release-it ci: update release process Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@abmusse
Copy link
Member Author

abmusse commented Sep 2, 2023

polite ping @kadler

Looks good, thought I think some of this stuff could be moved outside of the root. Both the release.sh and README section are really only relevant to us. Perhaps moving the docs to docs/RELEASE.md and putting release.sh under .github?

Can you please re-review after I moved files around as this PR is now going stale 😄

The steps for the release process are defined in
https://github.com/IBM/nodejs-idb-connector/blob/44065d373c458ae697294f9dee8ba9956bbc7ee9/docs/RELEASE.md
Let me know if this needs some changes.

@github-actions github-actions bot removed the stale label Sep 3, 2023
For more details on the release process, please read docs/RELEASE.md

In previous releases, we packaged the db2ia.node
and other extra files

Now we restrict the files packaged using the files section
of the package.json

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#files
@abmusse abmusse force-pushed the build-add-release-it branch from 44065d3 to 0628cc3 Compare February 1, 2024 22:43
@abmusse abmusse merged commit 94c8e89 into master Feb 2, 2024
1 check passed
@abmusse abmusse deleted the build-add-release-it branch February 2, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants