fix: non-204 successes with reference to response #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 92.79% 92.79% -0.01%
==========================================
Files 56 56
Lines 2124 2123 -1
==========================================
- Hits 1971 1970 -1
Misses 153 153
Continue to review full report at Codecov.
|
barrett-schonefeld
force-pushed
the
issue-135
branch
from
dc00cd5
to
2625f69
Compare
- use the resolvedSpec (all $refs dereferenced) to check if a response has content - removed the isRef variable because the resolvedSpec should not contain references - added a test that defines a spec with a reference to a response, preprocesses the spec and dereferences the response, then validates the response
barrett-schonefeld
force-pushed
the
issue-135
branch
from
2625f69
to
e9e8426
Compare
dpopp07
pushed a commit
that referenced
this pull request
Feb 11, 2020
## [0.19.2](v0.19.1...v0.19.2) (2020-02-11) ### Bug Fixes * resolve refs when checking for success response schemas ([#136](#136)) ([b286c69](b286c69))
|
🎉 This PR is included in version 0.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Tests:
Related issue: #135