Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operand phase error for Elasticsearch in OperandRequest #1049

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

YCShen1010
Copy link
Contributor

Issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/63588#issuecomment-80838597

Enhancement:

  • If the operator is not managed by ODLM, it will set the operatorPhase to Failed instead.
  • Clean up the phase value of OperandRequest and of each operand member at the beginning of each opreq reconciliation.

How to test

image: quay.io/yuchen_shen/odlm:operand_phase

  • Before applying the fix image:
    • request ibm-elasticsearch-operator
    • remove label and annotation in elasticsearch subscription:
      operator.ibm.com/opreq-control: 'true'
      cs-condition.example-service.ibm-elasticsearch-operator/request: v1.1
      
    • obverse operand phase failed in OperandRequest, even there is no operand for elasticsearch
      members:
       - name: ibm-elasticsearch-operator
         phase:
           operandPhase: Failed
      phase: Failed
  • Applying the fix image:
    • will see the error changes to operator failed (Assume the removed label and annotation are not added back at this time)
      members:
       - name: ibm-elasticsearch-operator
         phase:
           operatorPhase: Failed
      phase: Failed
    • add above label back to the subscription operator.ibm.com/opreq-control: 'true'
    • OperandRequest phase status is back to Running with
      members:
       - name: ibm-elasticsearch-operator
         phase:
           operatorPhase: Running
      phase: Running

Signed-off-by: YuChen <yuchen.shen@mail.utoronto.ca>
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 287eafa into IBM:master Jun 3, 2024
5 checks passed
@YCShen1010 YCShen1010 deleted the operand_phase branch June 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants