Use SelfSubjectAccessReview to check ODLM's permission on getting catalog #1100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
get
permission on resourcecatalogsources
in catalog namespacehasCatalogPermission := m.CheckResAuth(ctx, pm.Status.CatalogSourceNamespace, "operators.coreos.com", "catalogsources", "get")
SelfSubjectAccessReview
to validate its permission on certain resourcesWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65427
Test
openshift-marketplace
namespaceAlways
, change the verbosity from-v=1
to-v=2
and patch imagequay.io/daniel_fan/odlm:1b6ff4cb-dirty
ibm-im-operator
get
catalog inopenshift-marketplace
namespace.