Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event recorder #104

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/event recorder #104

wants to merge 3 commits into from

Conversation

vishal-ramani
Copy link
Member

Created new feature when application is started it will write an Kubernetes event in different conditions.
We can check those events via kubectl get events command.
Tested all scenarios as per our documentation with Kubernetes and OpenShift clusters.

@deleeuwblue
Copy link
Member

Hi Vishal. Thanks for completing this task. I have some comments:

operator-application/controllers/application/deployment.go

In this file, the event "Created deployment" is not really a Warning in my opinion. Could you make this event type corev1.EventTypeNormal?

operator-application/controllers/application/conditions.go

In this file, I think you are logging the same message twice with code:

log.Info("Application resource status update failed.")
log.Info(CONDITION_MESSAGE_DELETECONDITION)

Also, the const definitions would be better defined in the variables.go file. However, if changing this would require a lot of repeat testing then it also fine to leave the consts where they are in conditions.go.

@vishal-ramani
Copy link
Member Author

Hi @deleeuwblue
I have updated both the files with required changes. Can you please review and approve.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants