Added integration tests to Case Management SDK #16
Conversation
| var offeringType, _ = service.NewOfferingType(casemanagementv1.OfferingType_Group_CrnServiceName, "cloud-object-storage") | ||
|
|
||
| var ( | ||
| caseNumber = "CS1310378" |
There was a problem hiding this comment.
@huydoan2, I think having a fixed case number makes the integration testing fragile. Tests will fail if this case is permanently closed or customer provided their own credentials for integration testing. Instead of this, I did the following in other repos.
- Run a test that creates a new case
- Store the newly create case number (maybe a static variable?)
- Reuse the new case number in subsequent tests
There was a problem hiding this comment.
I remember doing exactly what you said. Not sure why that hard-coded case number is still there. Will fix!
There was a problem hiding this comment.
Also, if there are static values that the test needs to use (perhaps an id of a resource that the test depends on but doesn't create itself) we can easily add these values as additional config properties to the case_management.env file and then the test could just retrieve that during its initialization.
There was a problem hiding this comment.
We are good. Just fixed the usage of static variable. Thanks, Phil.
| Expect(*result.Status).To(Equal("Resolved")) | ||
| }) | ||
|
|
||
| It("Succefully unresolve a case", func() { |
There was a problem hiding this comment.
Just a heads up. Support org recently submitted a request as below.
- Customers should not be able to set the resolution code.
- Resolution codes should be hidden from customers.
- Only employees can set the resolution code.
We will have to make necessary changes to our API and to this test case.
There was a problem hiding this comment.
Thank you, Chong. Will modify the test case accordingly to how the API behaves in the future.
PR summary
Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information