Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Identity): adding Identity Preference API #261

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Nov 28, 2024

PR summary

preferences api
containing new api -CURD

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences branch from 0448c38 to 8e68818 Compare November 28, 2024 22:44
@padamstx padamstx self-assigned this Dec 2, 2024
@padamstx padamstx self-requested a review December 2, 2024 15:20
@padamstx
Copy link
Member

padamstx commented Dec 2, 2024

@pooraniss-ibm Looks like there are unit test errors in the build...

Edit: After digging into this a little more, it looks like the "delete_preferences_on_scope_account" operation incorrectly defines an "error" response body for the 204 - No Content response. An operation that returns a 204 status code should not return a response object. The API definition should be fixed and the code re-generated.

@padamstx
Copy link
Member

padamstx commented Dec 2, 2024

cc: @michaelbeck , cc'in you since Poorani is out on vacation.

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences branch 3 times, most recently from 45a8823 to 8675af6 Compare January 7, 2025 13:24
pooraniss-ibm and others added 3 commits January 9, 2025 12:40
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx force-pushed the iam-identity-preferences branch from 8675af6 to 3715840 Compare January 9, 2025 18:43
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit c51449b into main Jan 9, 2025
10 checks passed
@padamstx padamstx deleted the iam-identity-preferences branch January 9, 2025 19:14
ibm-devx-sdk pushed a commit that referenced this pull request Jan 9, 2025
# [0.61.0](0.60.2...0.61.0) (2025-01-09)

### Features

* **IAM Identity:** add Identity Preference API ([#261](#261)) ([c51449b](c51449b))
@ibm-devx-sdk
Copy link
Contributor

🎉 This PR is included in version 0.61.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants