Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portieris version to user agent for registry requests. #241

Closed
brackendawson opened this issue Jan 11, 2021 · 2 comments · Fixed by #252
Closed

Add portieris version to user agent for registry requests. #241

brackendawson opened this issue Jan 11, 2021 · 2 comments · Fixed by #252
Labels
enhancement New feature or request

Comments

@brackendawson
Copy link
Member

There's kind of a TODO here:

DockerRegistryUserAgent: "portieris", // add version?

@brackendawson
Copy link
Member Author

There are also two user agents in this package:

"User-Agent": []string{"portieris-client"},

@brackendawson
Copy link
Member Author

brackendawson commented Jan 11, 2021

It would be good to also set the user agent on this config struct for the kube API:

var config *rest.Config

There are also several other clients in the helpers directory that would benefit from one, such as oauth.

brackendawson added a commit to brackendawson/portieris that referenced this issue Jan 12, 2021
@sjhx sjhx added the enhancement New feature or request label Jan 12, 2021
@sjhx sjhx closed this as completed in #252 Feb 8, 2021
sjhx added a commit that referenced this issue Feb 8, 2021
fixes #241

Co-authored-by: Stuart Hayton <sjhx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants