Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support v1/cronjobs using 1.21 client #353

Merged
merged 5 commits into from
Oct 8, 2021
Merged

support v1/cronjobs using 1.21 client #353

merged 5 commits into from
Oct 8, 2021

Conversation

sjhx
Copy link
Member

@sjhx sjhx commented Sep 29, 2021

resolves: #350

Required increment of clientsets, to 1.21 and thus dropping v1alpha1/cronjobs

@sjhx sjhx changed the title support v1/cronjobs using 1.19 client support v1/cronjobs using 1.21 client Sep 30, 2021
@sjhx sjhx marked this pull request as ready for review October 1, 2021 08:39
jhart1685
jhart1685 previously approved these changes Oct 1, 2021
Copy link
Member

@jhart1685 jhart1685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, assuming e2e tests pass.

sjhx added 4 commits October 7, 2021 19:39
copyright-check

updates improved error msg / test

go.mod really using 1.9

support v1/cronjobs using 1.21 client
@sjhx
Copy link
Member Author

sjhx commented Oct 7, 2021

e2e tests pass

Copy link
Member

@jhart1685 jhart1685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjhx sjhx merged commit 159628d into master Oct 8, 2021
@sjhx sjhx deleted the v1-jobspec branch October 8, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeing The resource "batch/v1/cronjobs" is not supported. error from portieris on Openshift 4.8
2 participants