Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Remove the Vaadin Router patch #1

Closed
abdonrd opened this issue Jun 8, 2020 · 1 comment · Fixed by #341
Closed

Remove the Vaadin Router patch #1

abdonrd opened this issue Jun 8, 2020 · 1 comment · Fixed by #341
Labels
help wanted Extra attention is needed type: enhancement New feature or request

Comments

@abdonrd
Copy link
Member

abdonrd commented Jun 8, 2020

The Vaadin Router doesn't help us to restore scroll position on navigation.
There is already an issue about it: vaadin/router#43

Meanwhile, for now, we have created a simple patch to deal with it: now when you perform a click event, the scroll will be reset to the top position.

But we wish we could find a good solution soon.

We already mentioned it here:
https://github.com/IBM/pwa-lit-template#things-to-be-aware

@abdonrd abdonrd added type: enhancement New feature or request help wanted Extra attention is needed labels Jun 9, 2020
@abdonrd
Copy link
Member Author

abdonrd commented Feb 6, 2021

They merge this vaadin/router#547, so we can remove it when they release a new version.

@abdonrd abdonrd linked a pull request Feb 12, 2021 that will close this issue
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant