Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll to top on click event #547

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Conversation

haijian-vaadin
Copy link
Contributor

Apply @abdonrd 's patch to #43.
Not optimal, but maybe a good first step.

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this.

src/triggers/click.js Outdated Show resolved Hide resolved
@haijian-vaadin haijian-vaadin merged commit 43b0d3a into master Feb 4, 2021
@abdonrd
Copy link
Contributor

abdonrd commented Feb 4, 2021

@haijian-vaadin Thanks! Is there an estimate for the next release?

@haijian-vaadin haijian-vaadin deleted the haijian/scroll-to-top branch February 4, 2021 13:14
@haijian-vaadin
Copy link
Contributor Author

haijian-vaadin commented Feb 4, 2021

@haijian-vaadin Thanks! Is there an estimate for the next release?

Hi @abdonrd, I will try to cherry-pick this fix to 1.x and make a release next Friday (12.2.2012), maybe also make a 2.0 release as well.
And thanks a lot for your contributions to vaadin-router 🙇‍♂️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants