Skip to content

Commit

Permalink
Merge pull request #1418 from Shopify/kafka230
Browse files Browse the repository at this point in the history
Add support for Kafka 2.3.0
  • Loading branch information
bai authored Jul 2, 2019
2 parents 09dc31d + 1d96adf commit 2e58677
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ env:
- DEBUG=true
matrix:
- KAFKA_VERSION=2.1.1 KAFKA_SCALA_VERSION=2.12
- KAFKA_VERSION=2.2.0 KAFKA_SCALA_VERSION=2.12
- KAFKA_VERSION=2.2.1 KAFKA_SCALA_VERSION=2.12
- KAFKA_VERSION=2.3.0 KAFKA_SCALA_VERSION=2.12

before_install:
- export REPOSITORY_ROOT=${TRAVIS_BUILD_DIR}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ You might also want to look at the [Frequently Asked Questions](https://github.c
Sarama provides a "2 releases + 2 months" compatibility guarantee: we support
the two latest stable releases of Kafka and Go, and we provide a two month
grace period for older releases. This means we currently officially support
Go 1.10 through 1.12, and Kafka 2.0 through 2.2, although older releases are
Go 1.11 through 1.12, and Kafka 2.0 through 2.3, although older releases are
still likely to work.

Sarama follows semantic versioning and provides API stability via the gopkg.in service.
Expand Down
4 changes: 3 additions & 1 deletion utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ var (
V2_0_1_0 = newKafkaVersion(2, 0, 1, 0)
V2_1_0_0 = newKafkaVersion(2, 1, 0, 0)
V2_2_0_0 = newKafkaVersion(2, 2, 0, 0)
V2_3_0_0 = newKafkaVersion(2, 3, 0, 0)

SupportedVersions = []KafkaVersion{
V0_8_2_0,
Expand All @@ -183,9 +184,10 @@ var (
V2_0_1_0,
V2_1_0_0,
V2_2_0_0,
V2_3_0_0,
}
MinVersion = V0_8_2_0
MaxVersion = V2_2_0_0
MaxVersion = V2_3_0_0
)

//ParseKafkaVersion parses and returns kafka version or error from a string
Expand Down

0 comments on commit 2e58677

Please sign in to comment.