Merge pull request #1286 from aksdb/fix-heartbeat-deadlock

fixed potential deadlock when a heartbeat request fails
IBM · Feb 19, 2019 · dca1ba6 · dca1ba6
2 parents 6a7bac8 + 6c949c0
commit dca1ba6
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/consumer_group.go b/consumer_group.go
@@ -657,6 +657,12 @@ func (s *consumerGroupSession) heartbeatLoop() {
 		resp, err := s.parent.heartbeatRequest(coordinator, s.memberID, s.generationID)
 		if err != nil {
 			_ = coordinator.Close()
+
+			if retries <= 0 {
+				s.parent.handleError(err, "", -1)
+				return
+			}
+
 			retries--
 			continue
 		}