Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snappy Compression Support #1

Closed
eapache opened this issue Jul 19, 2013 · 3 comments · Fixed by #5
Closed

Snappy Compression Support #1

eapache opened this issue Jul 19, 2013 · 3 comments · Fixed by #5

Comments

@eapache
Copy link
Contributor

eapache commented Jul 19, 2013

Gzip support was trivial because it's built into the Go standard libraries. For snappy we'll have to add a dependency on some 3rd-party library.

Probably: https://code.google.com/p/snappy-go/

And for reference, because dependency management is bizarre in Go if you're used to a Gemfile: http://www.stovepipestudios.com/blog/2013/02/go-dependency-management.html

@fw42
Copy link
Contributor

fw42 commented Jul 19, 2013

Maybe have a look at this: https://github.com/d2fn/gopack

@eapache
Copy link
Contributor Author

eapache commented Jul 19, 2013

I feel like that goes against The Go Way.

@tobi
Copy link

tobi commented Aug 8, 2013

Agreed that gopack doesn't seem idiomatic for go.

I think the snappy dependency is ok.

eapache pushed a commit that referenced this issue Aug 8, 2013
@eapache eapache closed this as completed in #5 Aug 8, 2013
slaunay added a commit to slaunay/sarama that referenced this issue Dec 16, 2019
…oduce-pipeline

Support request pipeline in AsyncProducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants