-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit publishing of uncommited messages in functional_test #1733
Comments
So I had originally thought that there was just no support for the nescessary calls to do transactional publishing at all, but actually the low-level support in the Broker/Protocol interface does exist, it's just not part of the high-level producer interface. Just purely for the purpose of getting rid of the JAR, I wonder if something like this might work:
I haven't actually tried to run it but I can give it a shot when I get a moment and see how it goes. |
Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur. |
One of the pieces of #1695 was to use a small jar for publishing uncommited messages as part of the functional test:
https://github.com/Shopify/sarama/blob/221ed1a25150fa98d750f2e2f33f58ff018238b4/functional_test.go#L343-L345
What's missing from #1152 to allow us to do this in-house?
/cc @KJTsanaktsidis
The text was updated successfully, but these errors were encountered: