Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocks/consumer.go missing some documentation. #2374

Closed
emilienkofman opened this issue Oct 27, 2022 · 1 comment
Closed

mocks/consumer.go missing some documentation. #2374

emilienkofman opened this issue Oct 27, 2022 · 1 comment
Labels
stale Issues and pull requests without any recent activity

Comments

@emilienkofman
Copy link

Thank you for the great work. I was writing tests using the library and saw there's some documentation missing (minor issue). Hope it's the right place to report that.

Versions

sarama library v1.37.2

Problem Description

There's apparently some documentation missing from mocks/consumer.go, see
https://github.com/Shopify/sarama/blob/main/mocks/consumer.go#L208
hsweif added a commit to hsweif/sarama that referenced this issue Nov 11, 2022
@hsweif
doc: add missing sentences in a function comment
459b53e 
Refs: IBM#2374
@hsweif hsweif mentioned this issue Nov 11, 2022
Merged
dnwe pushed a commit to hsweif/sarama that referenced this issue Jul 18, 2023
@hsweif @dnwe
doc: add missing sentences in a function comment
85b96a3 
Refs: IBM#2374
@github-actions
Copy link

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the main branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Jul 27, 2023
dnwe pushed a commit to hsweif/sarama that referenced this issue Jul 27, 2023
@hsweif @dnwe
doc: add missing sentences in a function comment
6ff49a0 
Refs: IBM#2374
dnwe pushed a commit to hsweif/sarama that referenced this issue Aug 22, 2023
@hsweif @dnwe
doc: add missing sentences in a function comment
2a49dcb 
Refs: IBM#2374
@dnwe dnwe closed this as completed in 9282d75 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emilienkofman