Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not choke on MessageSet without version #1030

Merged
merged 1 commit into from
Feb 2, 2018

Commits on Feb 1, 2018

  1. Do not choke on MessageSet without version

    If we end un unlucky and MessageSet buffer is truncated right before
    we can read magic value, we just return `ErrInsufficientData`, even
    if some messages were previously successfully parsed.
    
    This propagates all the way up to `partitionConsumer`, where we zero
    parsed messages, which results in `ErrMessageTooLarge` returned
    to the consumer.
    
    This commit fixes the issue by setting `PartialTrailingMessage` to `true`
    on `MessageSet`, making it possible to read successfully parsed messages.
    bobrik committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    885c1b0 View commit details
    Browse the repository at this point in the history