Clear all metadata when we have the latest topic info #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I would have thought this would already work? If you refresh metadata for a topic that has been deleted, you should presumably get back Oh, I guess this fix is only needed for the refresh-all case? It seems like polling the specific topic would be more efficient for your client anyway? But I suppose this PR is still more correct. |
|
Yeah, this is only in the refresh all case, and I should actually just poll for the specific topic 😅, but this seems like undesired behaviour. |
eapache
reviewed
Feb 12, 2018
| @@ -685,7 +686,9 @@ func (client *client) updateMetadata(data *MetadataResponse) (retry bool, err er | |||
| for _, broker := range data.Brokers { | |||
| client.registerBroker(broker) | |||
| } | |||
|
|
|||
| if allKnownMetaData { | |||
| client.metadata = make(map[string]map[int32]*PartitionMetadata) | |||
There was a problem hiding this comment.
we should probably clear client.cachedPartitionResults here too then?
Mongey
force-pushed
the
cm-refresh-metadata
branch
2 times, most recently
from
00180fc
to
407fc37
Compare
Mongey
force-pushed
the
cm-refresh-metadata
branch
from
407fc37
to
0e0ee63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, If you list topics, then delete a topic, and poll to find out when the topic is actually deleted, it will never appear as deleted.
This is because
updateMetadatadoesn't remove topics that no longer exist from the metadata.An example can be seen over at terraform-provider-kafka
Here's a very naive solution that deletes the previous metadata, if you've got all the topic information from the broker.