Added support for Metadata Request/Response v1 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good to me; for symmetry it would be nice to have the broker's |
|
Thanks for the review, I'll add that and rebase |
V1 enables to discover the cluster controller which is required to send CreateTopics, DeleteTopics and CreatePartitions requests Co-authored-by: Adrian Preston <prestona@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
mimaison
force-pushed
the
metadata-v1
branch
from
554dd16 to
2e5395b
Compare
|
@eapache I've rebased on top of master and added the version field to broker's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V1 enables to discover the cluster controller which is required to send CreateTopics, DeleteTopics and CreatePartitions requests
So far we've just added the v1 request/response "definition" just enough so v1 requests can be sent using
Broker.GetMetadata()to find the controller.Clientis still using v0 metadata and also it would be nice to add aControllerfield toBroker.We can do that in another PR.Co-authored-by: Adrian Preston prestona@uk.ibm.com
Co-authored-by: Mickael Maison mickael.maison@gmail.com