Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Metadata Request/Response v1 #1047

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

mimaison
Copy link
Contributor

V1 enables to discover the cluster controller which is required to send CreateTopics, DeleteTopics and CreatePartitions requests

So far we've just added the v1 request/response "definition" just enough so v1 requests can be sent using Broker.GetMetadata() to find the controller.

Client is still using v0 metadata and also it would be nice to add a Controller field to Broker. We can do that in another PR.

Co-authored-by: Adrian Preston prestona@uk.ibm.com
Co-authored-by: Mickael Maison mickael.maison@gmail.com

@eapache
Copy link
Contributor

eapache commented Feb 13, 2018

Looks pretty good to me; for symmetry it would be nice to have the broker's encode also support the new version.

@mimaison
Copy link
Contributor Author

Thanks for the review, I'll add that and rebase

mimaison and others added 2 commits February 13, 2018 14:47
V1 enables to discover the cluster controller which is required to send CreateTopics, DeleteTopics and CreatePartitions requests

Co-authored-by: Adrian Preston <prestona@uk.ibm.com>
Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
@mimaison
Copy link
Contributor Author

@eapache I've rebased on top of master and added the version field to broker's encode. Can you have another look ?

@eapache eapache merged commit 96fcca4 into IBM:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants