Optional replica id in offset request #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, thanks. Sorry for taking so long to get back to this, but it would be great to have a test for this. |
jsoriano
force-pushed
the
offset-req-replica-id
branch
from
8563f1c
to
1900f52
Compare
ghost
added
the
jsoriano
force-pushed
the
offset-req-replica-id
branch
from
1900f52
to
56db864
Compare
jsoriano
force-pushed
the
offset-req-replica-id
branch
from
56db864
to
8869e90
Compare
jsoriano
force-pushed
the
offset-req-replica-id
branch
from
e8ab977
to
374f0e3
Compare
|
@eapache we have finally added tests and signed the CLA 🙂 Could you take another look? Thanks! |
2 tasks
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
SetReplicaIDto the OffsetRequest structure. IfSetReplicaIDhas not been used on an instance ofOffsetRequest,-1will be used when serializing the request.