Zstd support for compression #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this. Could we add some tests, similarly to how lz4 is tested? |
|
@bai good point. I started looking into that and hit DataDog/zstd#41. |
Decompress guess the size first then decompress so generally it takes much less allocation than iotuil.ReadAll which used a fixed buffer size of 512 bytes when message size is larger than 512 bytes. Creating ztsd.Reader for small messages is also costly because it has to perform additional cgo calls to initialize the context, compare to just 2 cgo call to decompress with a nil dst slice. Samething apply for Compress, it saves some cgo calls, and we dont reuse the writers anyway.
|
I've updated the PR with tests and a workaround for zero sized messages. |
|
❤️ |
|
This patch does not appear to actually work in practice without also incrementing the version of the producer and consumer protocol messages beyond |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIP-110 is finally accepted, so I can make a PR with something we've been using for quite a while now.
cc @dqminh, @andrew-plunk