Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encoding of MetadataResponse with version >= 2 #1174

Merged
merged 3 commits into from
Sep 26, 2018
Merged

fix encoding of MetadataResponse with version >= 2 #1174

merged 3 commits into from
Sep 26, 2018

Commits on Sep 26, 2018

  1. fix encoding of MetadataResponse with version >= 2 

    ThrottleTimeMs and ClusterID have been added to decode(), but apparently
encode() was forgotten. This causes errors in tests, if versions >= 2 are used.
    @birdayz
    birdayz committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    8d6be4e View commit details
    Browse the repository at this point in the history

  2. add missing error check

    @birdayz
    birdayz committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    b4a8a4a View commit details
    Browse the repository at this point in the history

  3. fix race condition in mock async producer 

    channels success and errors are not guaranteed to be closed before the channel
closed is closed. some tests, .e.g. TestProducerWithCheckerFunction relied on
this assumption, and produced race conditions (e.g. len(errors) is called after
producer.Close. with this change, close(mp.closed) is moved to the defer call,
after closing successes and errors.
    @birdayz
    birdayz committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    baa5962 View commit details
    Browse the repository at this point in the history