Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kafka 2.1.0 and fix CI #1229

Merged
merged 4 commits into from
Nov 28, 2018
Merged

Add support for Kafka 2.1.0 and fix CI #1229

merged 4 commits into from
Nov 28, 2018

Conversation

bai
Copy link
Contributor

@bai bai commented Nov 28, 2018

Old download URLs for kafka return 404 so I updated them with a new mirror.

Also fix make fmt condition to match all patch versions of Golang—instead of only matching 1.11.0 (make fmt would never run since we're already on 1.11.2).

Last but not least, add new version definitions and support for recently released Kafka 2.1.0.

@varun06 @muirrn could you please 👀this PR?

@@ -28,7 +27,7 @@ script:
- make test
- make vet
- make errcheck
- if [ "$TRAVIS_GO_VERSION" = "1.11" ]; then make fmt; fi
- if [[ "$TRAVIS_GO_VERSION" == 1.11* ]]; then make fmt; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bai bai merged commit 41db94b into master Nov 28, 2018
@bai bai deleted the fix-ci-mirror branch November 28, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants