Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a metric to expose consumer batch size #1296

Merged
merged 4 commits into from
Mar 13, 2019

Conversation

varun06
Copy link
Contributor

@varun06 varun06 commented Feb 28, 2019

This is an attempt to fix #1281

this is my first attempt to dabble in that code, let me know if it works, if not, where can I look.

@varun06
Copy link
Contributor Author

varun06 commented Feb 28, 2019

@bai can you have a look or I need someone else to guide me with this?

@varun06
Copy link
Contributor Author

varun06 commented Feb 28, 2019

It will also need some documentation updates, which I will do in later stage.

@bai bai requested a review from sam-obeid March 13, 2019 14:59
@bai
Copy link
Contributor

bai commented Mar 13, 2019

This looks good to me; looks like there's a minor conflict.

@varun06
Copy link
Contributor Author

varun06 commented Mar 13, 2019

Should be ready now.

Copy link

@sam-obeid sam-obeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bai bai merged commit 2b2fccd into IBM:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding consumer batch-size matric to sarama
3 participants