reduce client close bookkeeping #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
(fyi, I've now signed the CLA.) |
|
There is only 1 fail out of 6 tests, but I don't believe it has anything to do with the code I changed...? |
varun06
reviewed
Mar 1, 2019
| // through unchanged). This is for use in larger structs | ||
| // where it is undesirable to close the client that was | ||
| // passed in by the caller. | ||
| type nopCloserClient struct { |
There was a problem hiding this comment.
really like this pattern, we also do this wrapping pattern in one of our internal library. 👍
varun06
reviewed
Mar 1, 2019
varun06
approved these changes
Mar 1, 2019
|
Thank you! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of carrying around a symbol for
ownClient, just embed theClientpassed in by the caller with a wrapper that disables invokingClose().