Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request to please lint gods #1346

Merged
merged 1 commit into from
Apr 9, 2019
Merged

pull request to please lint gods #1346

merged 1 commit into from
Apr 9, 2019

Conversation

varun06
Copy link
Contributor

@varun06 varun06 commented Apr 8, 2019

No description provided.

@bai
Copy link
Contributor

bai commented Apr 8, 2019

whateverworks

@varun06
Copy link
Contributor Author

varun06 commented Apr 8, 2019

ha, exactly. @bai are we planning to cut a release soon. we have bunch of commits?

@bai
Copy link
Contributor

bai commented Apr 8, 2019

Yeah, I want to cut is asap. One thing that I wanted to include is support for zstd 1.3.8. Kafka 2.2.0 uses zstd 1.3.8, while we use DataDog's zstd 1.3.5.

If my zstd PR doesn't go through today, I'll compile changelog + make a release tomorrow.

@bai bai merged commit ad8cd49 into IBM:master Apr 9, 2019
@valyala
Copy link

valyala commented May 15, 2019

PTAL https://github.com/valyala/gozstd , which includes support for zstd 1.3.8 .

@bai
Copy link
Contributor

bai commented May 15, 2019

@valyala I bumped zstd dep in #1350. Out of curiosity, how's your implementation different from DataDogs?

@valyala
Copy link

valyala commented May 15, 2019

gozstd has the following features comparing to DataDog's zstd:

  • It vendors upstream zstd without any modifications in the zstd folder. The update process for the upstream zstd is easy - just run make update-zstd from the root of the repository. For example, I just updated the upstream zstd to v1.4.0 in this commit.
  • It is optimized for speed. The API may be easily used in zero allocations mode.
  • It provides faster and more efficient stream compression. It provides proper Writer.Flush call for network apps.
  • It supports dictionaries.

@bai
Copy link
Contributor

bai commented May 15, 2019

Thanks @valyala, will take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants