Custom auth handler interface #1365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
+1 |
|
About CLA: I can not sign CLA because it shows me my old email address. I signed it with my actual email address. I don't know why my old address is required... |
|
Closed due to better implementation in #1366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I would like to propose a custom handler interface for auth.
Sarama is missing Kerberos auth method, and PR #729 was closed due to external C library requirement. For that I've created custom implementation for kerberos auth (based on #729 PR and my research in librdkafka) that is using (and works!) this custom handler interface:
https://github.com/mieczkowski/sarama-kerberos/blob/master/kerberos.go
What do you think about that? :-)