Handle SASL/OAUTHBEARER token rejection #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk6i
changed the title
mk6i
changed the title
mk6i
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug (Issue #1423) in the SASL/OAUTHBEARER implementation where the Sarama client does not fail when the broker rejects the auth token and instead fails on the subsequent request following the auth flow.
This fix is based upon how the Java implementation handles token rejection.
The client handles SaslAuthenticate responses containing a non-empty challenge as an auth failure. Previously, Sarama only logged the challenge. The initial broker response containing the challenge does not contain an error code that can be raised to the client—the client must then make a subsequent request to the broker with a
\x01control character in order to terminate the token exchange and receive the error code from the broker, which is immediately surfaced to the client.cc @d1egoaz