Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure consistent use of read/write deadlines #1529

Merged
merged 1 commit into from
Oct 31, 2019
Merged

fix: ensure consistent use of read/write deadlines #1529

merged 1 commit into from
Oct 31, 2019

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Oct 30, 2019

The broker.go connection doesn't consistently set Read and Write
deadlines before performing read/write operations on the net.Conn. In
various scenarios if the broker stops responding that can cause the
given connection in the client to block indefinitely

Fixes #1528

The broker.go connection doesn't consistently set Read and Write
deadlines before performing read/write operations on the net.Conn. In
various scenarios if the broker stops responding that can cause the
given connection in the client to block indefinitely

Fixes #1528

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@varun06
Copy link
Contributor

varun06 commented Oct 31, 2019

Looks good.

-- FAIL: TestFuncProducingSnappy (1.43s)

    metrics_test.go:160: Expected histogram metric 'request-latency-in-ms' min >= 10, got 0

    metrics_test.go:160: Expected histogram metric 'response-size' min >= 1, got 0

@dnwe
Copy link
Collaborator Author

dnwe commented Oct 31, 2019

@varun06 yeah I think that's just an unrelated flakey test as all the other travis builds in the matrix passed and I couldn't reproduce that test failing locally. I'll try and trigger a travis rerun

@dnwe dnwe closed this Oct 31, 2019
@dnwe dnwe reopened this Oct 31, 2019
@bai bai merged commit 07c15a9 into IBM:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sarama broker connection can block forever if there is no response on the socket
3 participants