Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Allow TLS connections to work over socks proxy. #1666

Merged
merged 2 commits into from
May 5, 2020

Conversation

KevinJCross
Copy link
Contributor

It seems that the code was either proxy or tls but in my case I need tls over the socks proxy so Ive created this PR to fix this issue.
Note there seems to be an issue with the tls test where the server name was never set so Ive fixed that too.

@KevinJCross KevinJCross requested a review from bai as a code owner April 15, 2020 07:14
@ghost ghost added the cla-needed label Apr 15, 2020
@KevinJCross
Copy link
Contributor Author

@probot-shopify
CLA — Contributor License Agreement (CLA) status Signed :)

@KevinJCross
Copy link
Contributor Author

@github-actions CI / Go 1.13.x with Kafka 2.4.0 on Ubuntu (pull_request)

+ bin/zookeeper-server-stop.sh
No zookeeper server to stop
##[error]Process completed with exit code 1.

hmmm seems like an intermittant problem exists ;)

@ghost ghost removed the cla-needed label Apr 17, 2020
@d1egoaz
Copy link
Contributor

d1egoaz commented May 7, 2020

Note there seems to be an issue with the tls test where the server name was never set so Ive fixed that too.

@KevinJCross did you add the code for this?

bai added a commit that referenced this pull request May 9, 2020
* master:
  testfix: set KAFKA_HEAP_OPTS for zk and kafka
  testfix: give kafka longer to startup
  Creates conf.Net.TLS.Config if not provided
  Set ServerName using tls.DialWithDialer approach
  Reduce build matrix
  fix: Allow TLS to work over socks proxy. (#1666)
  AdminClient Test Handle errors with no message
  Handle errors with no message
  Add a functional test to cover idempotent production
  Fix "broker received out of order sequence" when brokers die
  Add DescribeLogDirs to admin client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants