fix: set min-go-version to 1.16 #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
troyanov
force-pushed
the
bump-min-go-version
branch
from
834b8f6
to
f68e251
Compare
troyanov
changed the title
Changes that were introduced in 8ccea19 made it impossible to compile sarama with go 1.15 (which is mentioned as officially supported version in the README file) io.Discard and io.ReadAll appeared only in 1.16 https://golang.org/doc/go1.16#ioutil To address this issue this commit bumps minimal supported go version defined in go.mod file, to provide a clear message that 1.16 is required ``` > go build ./config.go:678:37: undefined: io.Discard ./decompress.go:43:10: undefined: io.ReadAll ./decompress.go:55:10: undefined: io.ReadAll ./sarama.go:89:29: undefined: io.Discard note: module requires Go 1.16 ```
troyanov
force-pushed
the
bump-min-go-version
branch
from
f68e251
to
440ea78
Compare
Stephan14
approved these changes
Oct 9, 2021
dnwe
approved these changes
Oct 9, 2021
Merged
1 task
1 task
This was referenced Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that were introduced in 8ccea19 made it impossible to compile sarama with go 1.15
(which is mentioned as officially supported version in the README file)
io.Discardandio.ReadAllappeared only in 1.16https://golang.org/doc/go1.16#ioutil
To address this issue this commit bumps minimal supported go version
defined in go.mod file, to provide a clear message that 1.16 is required
Also it looks like that support of go 1.15 was also dropped in the CI workflow by 974e37b and 1.16 is the min version that is currently being checked https://github.com/Shopify/sarama/blob/main/.github/workflows/ci.yml#L16