fix: ensure heartbeats only stop after cleanup #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sarama would immediately stop heartbeating on rebalance. If the session teardown took longer than the session timeout, it would get evicted from the group. This can be fixed by ensuring that heartbeats only stop _after_ the session has completed its cleanup process. Contributes-to: #1608
ghost
added
the
|
@pavius similarly, I extracted this change out of your original issue and fork so we can test and review it in isolation — thanks for your work on this, please could you sign the CLA? |
|
@pavius 👋🏼 Friendly bump 🙏🏼 We're about to cut a new release - do you think you could sign CLA to unblock us? I'd appreciate it so much. ❤️ |
|
Signed :) |
bai
approved these changes
Jan 21, 2022
This was referenced Feb 1, 2022
Merged
This was referenced Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sarama would immediately stop heartbeating on rebalance. If the session teardown took longer than the session timeout, it would get evicted from the group.
This can be fixed by ensuring that heartbeats only stop after the session has completed its cleanup process.
Contributes-to: #1608