fix: prevent metrics leak when authenticate fails #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broker register metrics name to `registeredMetrics` and then authenticate to broker by socket, when authenticate failed many times, the `registeredMetrics` is slice and will append a metrics name many times
dnwe
changed the title
dnwe
approved these changes
Apr 13, 2022
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broker register metrics name to
registeredMetricsand thenauthenticate to broker by socket, when authenticate failed many times,
the
registeredMetricsis slice and will append a metrics name manytimes
Fixes #1960