Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIP-345: support static membership #2230

Merged
merged 1 commit into from
May 30, 2022
Merged

KIP-345: support static membership #2230

merged 1 commit into from
May 30, 2022

Conversation

aiquestion
Copy link
Contributor

@aiquestion aiquestion commented May 16, 2022

Hi this is the impl for kip-345 static membership, pls help to take a look.

  • update joingroup/syncgroup/heartbeat/commitoffset request
  • donot leavegroup if staticmembership is enabled
  • with ut&functional test
  • added logic for KIP-394 if static membership is enabled. because we update the joingroup.

@ghost ghost added the cla-needed label May 16, 2022
@ghost ghost added cla-needed and removed cla-needed labels May 16, 2022
@aiquestion aiquestion changed the title KIP-394: support static membership WIP: KIP-394: support static membership May 16, 2022
@aiquestion aiquestion changed the title WIP: KIP-394: support static membership KIP-345: support static membership May 17, 2022
@dnwe
Copy link
Collaborator

dnwe commented May 23, 2022

many thanks for this contribution @aiquestion — if you are happy to go ahead and sign the Shopify CLA here then I can proceed to review the changes

@aiquestion
Copy link
Contributor Author

@dnwe thanks~ i think i signed the CLA before. and when i tried to sign it again, got an error "GitHub username has already signed a CLA"

@dnwe
Copy link
Collaborator

dnwe commented May 23, 2022

@aiquestion ah it looks like probot is confused because your first commit is under a gmail.com e-mail address that maps to your public GitHub username, but the second and third commit have been done under your company e-mail address and that isn't registered to your public GitHub account. That explains why the cla-required label was added then removed and then added back again.

Please can you git rebase origin/main --exec 'git commit --amend --author="Author Name <email@address.com>" --no-edit' (or equivalent in your UI tool of choice) to rebase on main and reset the author to a single consistent one?

@aiquestion
Copy link
Contributor Author

fixed it. And also revert the gomod change to avoid conflict. thanks

Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aiquestion thank you, this is a really great first contribution to Sarama. Good test coverage and easy to read and understand the code changes. Thanks for your hard work!

@dnwe dnwe added the feat label May 30, 2022
@dnwe dnwe merged commit 53e77a4 into IBM:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants