Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off probot-CLA to new GitHub Action #2294

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

cursedcoder
Copy link
Contributor

Hello 👋

We are deprecating probot usage, so all Shopify repos should be migrated to use new GitHub CLA Action.

You can see how this works in vscode-shopify-ruby repo.

If you have any questions, please reach us on Slack.

After you merge this PR, make sure to update branch protection settings (if you have any):

  1. Go to Settings > Branches > Edit main (or any default) branch
  2. Remove the CLA check from probot (click x): image
  3. Add CLA check from GitHub action: image

** In order for the cheak to appear on the list, the workflow should be ran for at least 1 time, so after you merge this PR, add comment with text signed, then refresh the settings page.

How to trigger workflow on existing PRs:

There are few ways how to start the check on PRs created before this change:

a) Close and reopen PR:
image
b) Push empty commit to trigger the events: git commit --allow-empty -m "wakey wakey GitHub Actions"

@dnwe
Copy link
Collaborator

dnwe commented Jul 26, 2022

@cursedcoder happy to merge this, but I don't know who is available to modify the Settings to remove the old Probot check. I'm not a Shopify employee and I don't have administrator access to Sarama's repo.

@dnwe dnwe merged commit 63ed4e1 into main Jul 26, 2022
@dnwe dnwe deleted the replace-cla-probot-with-action branch July 26, 2022 13:28
@dnwe
Copy link
Collaborator

dnwe commented Jul 26, 2022

Signed

@cursedcoder
Copy link
Contributor Author

@dnwe thanks!

I just checked and your repo doesn't require any change, so it's totally ok as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants