Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support key in MockFetchResponse. #2328

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

Skandalik
Copy link
Contributor

While working with MockBroker, I found out that this mock doesn't support key in the message for FetchRequest. In my case having key mocked is essential as in the project I'm working on, we rely on the parsed key from Kafka message.
I added the support and added the test for this behavior.

@Skandalik
Copy link
Contributor Author

Skandalik commented Sep 7, 2022

CLA signed.

@Skandalik Skandalik changed the title Support key in MockFetchResponse. feat: support key in MockFetchResponse. Sep 9, 2022
@Skandalik
Copy link
Contributor Author

@dnwe Could you please review the PR? I don't know if I should create an issue too.

@dnwe dnwe added the feat label Sep 15, 2022
@dnwe dnwe merged commit eb5895f into IBM:main Sep 15, 2022
@Skandalik Skandalik deleted the mock-fetch-response-key-support branch September 20, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants