fix(producer): replace time.After with time.Timer to avoid high memory usage #2355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sarama allows several options to control how often to flush a batch of messages to brokers. It utilizes
time.After
to control the frequency of a flush. However, it would cause high memory usage in some cases.I've written the following example with
Flush.Messages = 1
andFlush.Frequency = time.Second * 60
to demonstrate it. In practice, the situation could be even worse since there could be multiple broker producers in one producer and multiple producers in one instance/machine.Since the message flushes very quickly, a new timer will be created every time in
time.After
, which won't be garbage collected until expiration, thus causing high memory usage.logs before optimization
Following the guideline in https://pkg.go.dev/time#After, I simply replace
time.After
withtime.NewTimer
and manually stop timer every time when callingbp.rollover
. And as shown in the below logs, the memory usage decreses a lot as expected.logs after optimization