Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove NewConsumerFromClient method call in newConsumerGroup method #2423

Closed
wants to merge 3 commits into from
Closed

fix: remove NewConsumerFromClient method call in newConsumerGroup method #2423

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37d944f
fix: remove NewConsumerFromClient method call in newConsumerGroup method
Jan 19, 2023
51ed865
fix: use the newConsumer method
Jan 19, 2023
3e065fd
fix: fix contributor email
Lumotheninja Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions consumer_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,17 @@ func newConsumerGroup(groupID string, client Client) (ConsumerGroup, error) {
return nil, ConfigurationError("consumer groups require Version to be >= V0_10_2_0")
}

consumer, err := NewConsumerFromClient(client)
if err != nil {
return nil, err
c := &consumer{
client: client,
conf: client.Config(),
children: make(map[string]map[int32]*partitionConsumer),
brokerConsumers: make(map[*Broker]*brokerConsumer),
metricRegistry: newCleanupRegistry(client.Config().MetricRegistry),
Lumotheninja marked this conversation as resolved.
Show resolved Hide resolved
}

cg := &consumerGroup{
client: client,
consumer: consumer,
consumer: c,
config: config,
groupID: groupID,
errors: make(chan error, config.ChannelBufferSize),
Expand Down