Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct HighWaterMarkOffset of mocks partition consumer #2447

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

gr8web
Copy link
Contributor

@gr8web gr8web commented Mar 3, 2023

Currently the message offset and the HighWaterMarkOffset differs by 2 and was not part of the test as it was changed in #2078.

@gr8web gr8web force-pushed the mock-consumer-offset branch 2 times, most recently from 57d4b64 to a362aa0 Compare March 3, 2023 10:05
@dnwe dnwe added the fix label Mar 3, 2023
@gr8web
Copy link
Contributor Author

gr8web commented Mar 6, 2023

Changed HighWaterMarkOffset values in TestConsumerHandlesExpectationsPausingResuming which was reported as failed.

Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dnwe dnwe merged commit 2f8dcd0 into IBM:main Mar 23, 2023
@dnwe dnwe changed the title Fix HighWaterMarkOffset of mocks partition consumer fix: correct HighWaterMarkOffset of mocks partition consumer Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants