Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore (*OffsetCommitRequest) AddBlock func #2494

Merged
merged 1 commit into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. fix: restore (*OffsetCommitRequest) AddBlock func

    In v1.34.0 a breaking API change to (*OffsetCommitRequest) AddBlock was
    inadvertently introduced by 59a3d39
    We weren't aware that anyone was driving the offset commit protocol
    directly via the broker.go call rather than via offset_manager.go (or
    via a consumer client)
    
    For now we restore the old AddBlock signature and move the new one to
    AddBlockWithLeaderEpoch. This will unfortunately impact anyone who had
    updated their own code to call the new func signature, but it's probably
    more important that we restore the longer term backwards compatibility
    now until we move to a v2 release.
    
    Fixes #2358
    
    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    dnwe committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4b9e8f6 View commit details
    Browse the repository at this point in the history