fix(test): allow testing of skipped test without IsTransactional panic #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
dnwe
approved these changes
Jul 26, 2023
ioanzicu
pushed a commit
to ioanzicu/sarama
that referenced
this pull request
Jul 31, 2023
IBM#2525) Signed-off-by: Mark Hindess <mark.hindess@gmail.com> Signed-off-by: Ioan Zicu <ioan.zicu@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently skipped but I was planning to look at flakiness in the functional tests so I thought I'd make this one not panic due to nil txnmgr.