Add support for up to version 4 List Groups API #2541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for versions 1 through 4 of the ListGroups API.
A compromise for backwards compatibility is the addition of a new
GroupsData
field to the list groups response, leaving the existingGroups
field unchanged:A more faithful, yet incompatible, rendering for this part of the Kafka protocol (see below) would have been to change the type of the existing
Groups
field to be a map ofstring
(group ID) to astruct
with fields for "protocol_type" and "group_state".Ideally, if any further fields are added into the "groups" section of the protocol, they will be added into the
GroupsData
field of theListGroupsResponse
struct.Contributes-to: #2408