fix(proto): use full range of MetadataRequest #2556
Merged
+49
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
force-pushed
the
dnwe/metadata-request
branch
from
1c16c90
to
003cae7
Compare
hindessm
reviewed
Aug 4, 2023
| @@ -17,6 +17,10 @@ func NewMetadataRequest(version KafkaVersion, topics []string) *MetadataRequest | |||
| m.Version = 6 | |||
| } else if version.IsAtLeast(V1_0_0_0) { | |||
| m.Version = 5 | |||
| } else if version.IsAtLeast(V0_11_0_0) { | |||
There was a problem hiding this comment.
FYI: I prefer these else if highest first which makes me dislike those if {}; if {} lowest first additions I queried yesterday even more.
There was a problem hiding this comment.
@hindessm I agree it's nicer and it works here because there's no mandatory additional fields, just the version number being set.
However, In some of those other cases it (e.g.,) needs a mandatory field included from V4 upward, so an additive approach works better.
One additional thing I did like about Metadata was that it puts the version choice logic alongside the proto definition rather than within client.go / broker.go / consumer.go etc.
hindessm
approved these changes
Aug 4, 2023
dnwe
force-pushed
the
dnwe/metadata-request
branch
2 times, most recently
from
f401b55
to
34828a0
Compare
Even though most of these are identical, we may as well match up correctly. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
dnwe
force-pushed
the
dnwe/metadata-request
branch
from
34828a0
to
09ced0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though most of these are identical, we may as well match up correctly.
Contributes-to: #2408